Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that env special case handling is missing in some case #4887

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the issue that env special case handling is missing in some case

Which issue(s) this PR fixes:

Fixes #4884

Brief changelog

  • move the special env handling logic to getWellFormName so that all the cases are covered.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #4887 (014cf1a) into master (a1bf9eb) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4887      +/-   ##
============================================
- Coverage     48.47%   48.43%   -0.05%     
+ Complexity     1726     1725       -1     
============================================
  Files           346      346              
  Lines         10835    10836       +1     
  Branches       1080     1080              
============================================
- Hits           5252     5248       -4     
- Misses         5259     5266       +7     
+ Partials        324      322       -2     
Impacted Files Coverage Δ
...ctrip/framework/apollo/portal/environment/Env.java 92.75% <100.00%> (+0.10%) ⬆️

... and 3 files with indirect coverage changes

@nobodyiam nobodyiam requested a review from a team May 28, 2023 23:56
@nobodyiam nobodyiam merged commit 971b412 into apolloconfig:master Jun 6, 2023
@nobodyiam nobodyiam deleted the fix-env-special-case branch June 6, 2023 01:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“ConfigDB配置管理”环境列表显示报错,2.1.0版本“prod”环境标
1 participant